Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submission in s3 even after review state is updated #1379

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

Previously, submissions were updated to S3 by checking the last submission date, but if someone changes the review state, it won't change the date due to which submission wasn't updated. This PR adds the review state to the submission meta json in s3, which is compared with the review state obtained from odkcentral. Those obtained lists of review states are converted into hash strings so that they can be compared easily without going through every element of the list.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock merged commit ee9e0ca into development Mar 22, 2024
5 checks passed
@spwoodcock spwoodcock deleted the refactor/update-review-state-s3 branch March 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants