Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate endpoint to check the validity of login cookies. #1380

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

Sujanadh
Copy link
Collaborator

@Sujanadh Sujanadh commented Mar 22, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR adds new endpoint that checks for login cookie validity. Returns True if valid and False for the invalid cookie.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

"""Verifies the validity of login cookies.

Returns True if authenticated, False otherwise.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff πŸ˜„

Thinking about it, the endpoint may as well return the actual user data json, as the frontend could then update the profile picture if it changed since last login πŸ‘

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@spwoodcock spwoodcock merged commit e1b871c into development Mar 25, 2024
5 checks passed
@spwoodcock spwoodcock deleted the feat/check-login branch March 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend login state is sometimes incorrect
2 participants