Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle geo orientation crash on Firefox and Safari #1381

Conversation

NSUWAL123
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Firefox and safari Sensor API uncompatibility.

Describe this PR

This PR displays error toast to user & only shows blue circular location dot if their browser is firefox or safari since it doesn't support sensor API.

Screenshots

Screenshots from firefox browser:
image_720
image

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock
Copy link
Member

Nice solution!

@spwoodcock spwoodcock merged commit 4125867 into hotosm:development Mar 22, 2024
3 checks passed
@spwoodcock spwoodcock changed the title Feat project details geolocation integration Handle geo orientation crash on Firefox and Safari Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants