Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate response for comment and task status history #1391

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR refactors the end point task_history using raw sql returning separate response for comments in task and task status history.
We dont need separate comment get endpoint now.

Response

[
  {
    "id": 110,
    "project_id": 236,
    "task_id": 2350,
    "action": "RELEASED_FOR_MAPPING",
    "action_text": "Status changed from READY to LOCKED_FOR_MAPPING by: svcfmtm",
    "action_date": "2024-03-26T04:32:15.998587",
    "status": "LOCKED_FOR_MAPPING"
  },
  {
    "id": 111,
    "project_id": 236,
    "task_id": 2347,
    "action": "RELEASED_FOR_MAPPING",
    "action_text": "Status changed from READY to LOCKED_FOR_MAPPING by: svcfmtm",
    "action_date": "2024-03-26T04:32:20.254619",
    "status": "LOCKED_FOR_MAPPING"
  }
]

comments

[
  {
    "id": 112,
    "project_id": 236,
    "task_id": 2349,
    "action": "COMMENT",
    "action_text": "<p>this is test comment for task id 2349</p>",
    "action_date": "2024-03-26T04:33:41.524730",
    "status": null
  }
]

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh self-assigned this Mar 26, 2024
@spwoodcock spwoodcock merged commit e62df22 into development Mar 26, 2024
5 checks passed
@spwoodcock spwoodcock deleted the refactor/task-history branch March 26, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments and Task History in Same Response
2 participants