Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

add back doc build and deploy #65

Merged
merged 1 commit into from Jan 23, 2017
Merged

add back doc build and deploy #65

merged 1 commit into from Jan 23, 2017

Conversation

smit1678
Copy link
Collaborator

Should fix API docs build and deploy to gh-pages.

Fix #47

@smit1678 smit1678 assigned mojodna and unassigned mojodna Jan 23, 2017
@smit1678 smit1678 requested a review from mojodna January 23, 2017 15:42
mojodna
mojodna approved these changes Jan 23, 2017
View reviewed changes
Copy link
Collaborator

@mojodna mojodna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, 👍

It does bother me that it rewrites gh-pages history on each commit. The gh-pages CLI wraps up the git/GitHub repo management and would make a nice improvement here.

@smit1678
Copy link
Collaborator Author

It does bother me that it rewrites gh-pages history on each commit. The gh-pages CLI wraps up the git/GitHub repo management and would make a nice improvement here.

Yeah agreed. I haven't looked at the gh-pages cli and that would definitely improve. Going to merge and then we can capture that in a separate issue for improvement.

@smit1678 smit1678 merged commit db720e5 into develop Jan 23, 2017
@smit1678 smit1678 deleted the fix/travis-doc-deploy branch January 23, 2017 17:35
@mojodna
Copy link
Collaborator

mojodna commented Jan 23, 2017

See #67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mojodna mojodna mojodna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Docs don't load
2 participants
@smit1678 @mojodna