Fix key-vault name length constraint #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Key Vault names are universally unique. To make sure there are no name collisions with the new production Key-Vault, a random_pet resource was used as a prefix. But Azure Key Vault has a constraint for name length (8-24 chars). To fix it, random_string is being used instead of `random_pet`. The string length is set to 3 to accommodate long project names and deployment environment labels.
eternaltyro
added
bug
|
Commit will destroy and create two resources. (and create key vault fresh) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Key Vault names are universally unique.
To make sure there are no name collisions with the new production Key-Vault, a random_pet resource was used as a prefix. But Azure Key Vault has a constraint for name length (8-24 chars). To fix it, random_string is being used instead of
random_pet. The string length is set to 3 to accommodate long project names and deployment environment labels.