Bugfix for default comment #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-hotosm
added a commit
that referenced
this pull request
Jul 26, 2017
* BUGFIX - Remove dev column from Migration script * bugfix legend translate (#406) bugfix legend translate + fix typo land use * add meta tags (#412) * second try (#413) * Project Clone Back-End (#414) * work on clone * Work on project clone * Initial work on clone * More work on cloning * Remove api * Add clone option to create API * Remove cruft * Refactor AOI Table (#418) * Work on refactor * Work on refactor * Fix bugs * Remove cruft * Finish up refactor (#419) * Modify task count query (#420) * Ht 169 get projects v1 (#421) Get projects geojson by bounding box * Ht 169 get projects 2 (#424) fix swagger docs for authentication token * Bugfix for AOI on project clone (#425) * Bugfix for default comment (#426) * Bugfix for default comment * Fix breaking tests * Project clone ui (#417) * project clone wip * project clone * tidy up * BUGFIX - Serialise priority areas correctly * Add order by project id (#459) * CircleCI and HOTOSM Setup (#415) Adds CircleCI config, a deployment script for ElasticBeanstalk, and additional environments (demo, stage, prod) * switch to develop branch for deploy while reviewing git branching model (#465) * run all branches through circleci (#466) * Reset config for thinkwhere * remove character limit on project lists (#469) * remove character limit on project lists * update UI to API change 6 projects * Ht 169 get projects v2 (#467) * api v2 * fixed tests * move geojson to files * make createdByMe request param * Per task instructions (#468) * Work on per-task-instructions * Per task initial work * More work on per task instructions * Update test and migration * Reject split tasks * Tidy up code * Refactored for to allow tests to pass * Remove cruft * Settings api mapper levels (#473) * Enhacne settings API with mapper levels * Remove cruft * Update README.md * added some unit tests and made logic more obvious (#474) * added some unit tests and made logic more obvious * tweak * Add more user friendly error * fixed test * Update service to use config values (#475) * Add localisation to mapping APIS (#476) * change upload value on osmxml to false (#477) This PR should resolve issue raised in #477 * Add localistion to validation apis (#478) * change order of JOSM commands and force OSMXML download to new layer (#479) * Refactor task dto (#481) * Localise split task * Refactor task * Refactor namespace (#483) * Create grid namespace * Add namespace * Move into namespace * Other projects aoi (#472) Show the AOI of projects on the project dashboard and during project creation * Per task instructions ui (#482) * per task instructions UI * tweak * bugfix messages not found (#485) * Refresh mapper level (#487) * Refresh mapper level * Add test * Add calls to update * Progress bar levels (#486) * progress bar mapper levels * profile page changes * Rename settings API * dashboard projects descending (#488) * Bugfix - for split task with instructions * use new settings api name (#489) * Bugfix for empty sender * Bugfix for empty sender * Image header homepage (#490) * add progress bar for advanced users (#491) * Fix bug with refreshing mapper level (#492) * BUGFIX - Correct thinkwhere staging config * set layer names in JOSM + tag OSM xml with upload=never' (#496) * set layer names in JOSM + tag OSM xml with upload=never' * fix imagery error messages * do a zoom only if more than one task * adjust comments * Show pointer cursor when hovering a task (#494) * Additional validation metrics (#495) * Validation work * Return dates in validation response * Add validation metrics * Bugfixes profile filtering (#498) * bugfix 401 redirect * fix for filtering contribute page * bugfix mapper levels * add URL params to search * Handle all param, fix broken test (#508) * humanitarian-osm (#507) * hot osm settings (#511) * fix overlay autopan (#512) * Bugfix - Ensure counters set for validate, invalidate all (#497) * Ensure stats set when validating, invalidating * Add tests * Set properties correctly on val-inval all * Handle bad imagery counts * use ALL mapping difficulty search param (#513) * keep timer running if not navigating to different page (#515) * bugfix url params search all (#516) * More metrics mapper selection v2 (#514) * encode mimetype param on load_data JOSM request * bugfix getting user async (#517) * Per project chat (#518) * Initial work on chat * Work on project chat * Initial work on get chat messages (#520) * fix for loading header translations (#519) * fix for loading header translations * no translatable title * reset the lockedTasksForCurrentUser (#521) * metrics UI changes (#524) * show no validator role message on Validate tab (#523) * Add alerts if you are @d in message (#522) * Add bleach to sanitize input (#525) * Add caching (#526) * Flake8 (#528) * Flake8 tidyups for API * Flake8 tidyups * OPS - Upgrade dependencies (#531) * Update dependencies * Update dependencies * Change order to newest last * Default mapper level all (#534) * default mapper level to all * tidy up * tidy up * Per project chat (#533) * per project chat * delete deleted files * tweak docs * Allow users to view Unpublished / Archived projects (#537) * Allow users to view Unpublished / Archived projects * add project status to client description page * Chat enhancements (#540) * add interval * chat enhancements * handle tab url param * get and set last used editor to a cookie as favourite editor (#538) * added a userPreferencesService and a favouriteEditor item to keep track of editor used by user * code review changes * Fix link in chat alert * Project search v2 (#541) * Add caching * Make compatible with existing functionality * Docs * return mapResults as a geojson feature class * tidy up * remove redundant geojson import * Allow users to remove email address (#542) * route reload on project create + tidy up project UI (#548) * Contribute map view (#547) * modify put map on separate tab * modify put map on separate tab * get features and add to vector and cluster layer * feaure popup working from GET project api * added docs * Bugfixes for chat caching and ordering * Task link in comment (#550) * allow one zoom level out for showing other projects (#549) * allow one zoom level out for showing other projects * remove console.log * chat enhancements (#554) * remove unused properties (#555) * validate aoi on import (#557) * Project summary api (#558) * Work on summary * Work on summary * Summary info * Final work on summary * Project summary api * Ensure email alert opens inbox (#562) * Add caching on user-services (#564) * image credit home page (#563) * List view longer title (#561) * give 25% space to project title in list view * tweak * Fixups and tidyups (#565) * Add debug * Bugfix - Fix search all users filter * Ht 189 project summary api (#566) * use prject summary api + add scroll bar to short desc. * hide schort desc if not present * reset cluster threshold to null on each initialisation of projectMapService * wrap pop text with translate markup * Ui enhancements v2 (#567) * only get chat messages on /project * add error handling users list * message all users * align overview toggle * add legend dashboard + close popup black * hide pagination users if no results * contact details positioning * fix test * fix test * title linkedin tweak * dont show tick when no email address * Upgrade showdown (#573) * upgrade showndown library * typo * Josm no single task layer (#574) * use prject summary api + add scroll bar to short desc. * hide schort desc if not present * reset cluster threshold to null on each initialisation of projectMapService * wrap pop text with translate markup * no task layer if one task * tidy up * allow 2 zoom levels further out (#575) * remove console.log * check for {x}, {y}, {z} place holders anywhere in the per task instru… (#578) * check for {x}, {y}, {z} place holders anywhere in the per task instructions * fix splittable flag * tweak OSM data layer name on launch of JOSM * allow bad imagery to be locked for validation (#581) * Josm zoom (#596) * add zoom * remove returns * Adds translation decorators to new strings (#582) * Updates locale translation files * Fixing typo (#601) * use $routeChangeStart instead of $locationChangeStart to detect navigation away from project page (#603) * use instead of to detect navigation away from project page * remove console.log * Fix login (#607) * fix login redirect * tweak docs * add docs * Add support for extra_properties in per task instructions (#593) * Add support for extra_properties in per task instructions for arbitrary polygons * Add task_creation_mode to project * Add spatial index for geom (#604) * Fix issue with locked tasks and invalidate all (#624) * Migrate fixup (#625) * Revert "Add support for extra_properties in per task instructions (#593)" This reverts commit 2b69e98. * Revert "Add support for extra_properties in per task instructions (#593)" (#626) This reverts commit 2b69e98. * Migrate update (#586) * Fixups to migration scripts * Correct schema * Unselect task on click off (#642) * Override nginx timeout and request size defaults (#645) * Revert nginx config (#646) * Revert "Add support for extra_properties in per task instructions (#593)" This reverts commit 2b69e98. * Revert "Override nginx timeout and request size defaults (#645)" This reverts commit 03fd401. * Nginx config 2 (#647) * Revert "Add support for extra_properties in per task instructions (#593)" This reverts commit 2b69e98. * Allow bigger requests and extend timeout * remove project task count limit and add error message for trim timout and unexpected error (#643) * Select again (#648) * wip * further wip * more wip * added docs * tidy up * show history and add preview button (#649) * Project clone bugfix (#652) * Revert "Add support for extra_properties in per task instructions (#593)" This reverts commit 2b69e98. * Bugfix for private projects * invalid project error handling (#651) * Is undoable flag (#654) * Revert "Add support for extra_properties in per task instructions (#593)" This reverts commit 2b69e98. * Add isUndoable flag on get task * Add tests * Add initial undo logic * Update stats * Docs * Add locale * Bugfix for get-task * Allow mixed case tags (#656) * Only send one message when validating mutiple tasks (#657) * undo button (#655) * removes hardcoded SMTP variables (#658) * Fix migration error (#662) * Bugfix, add missing semi-colon * Bugfix - remove cruft * Bugfix - Add missing schema * Bugfix - Missing schema again * updates prod url (#664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve issue #410 where the projectId was missing from the default changeset comment.