Parse new database connection parameters #4612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemarcel
approved these changes
May 4, 2021
willemarcel
added
scope: infrastructure
type: enhancement
|
@eternaltyro before merging, could you document the new variable on https://github.com/hotosm/tasking-manager/blob/develop/example.env and on https://github.com/hotosm/tasking-manager/blob/develop/docs/deploy-aws.md |
Problem: There's no straightforward way to prevent PostgreSQL password from being displayed in AWS console (our current application host). This is a shortcoming of AWS Cloudformation and available options for AWS ECS `ValueFrom` field. Solution: Instead of trying to parse the secrets manager entry and pick specific parameters in the CloudFormation template, we do the parsing in config.py and pass the whole JSON stored in secrets manager. This is agnostic of AWS and can be extended to any cloud provider or server host in the future.
eternaltyro
force-pushed
the
feature/db-connection-parameters
branch
from
7c7ad99
to
9b5ef2a
Compare
Wille, I've updated example.env. The AWS deploy documentation will need more tuning and I think it's better if I merge it along with the rest of the CloudFormation code for it to make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There's no straightforward way to prevent PostgreSQL password
from being displayed in AWS console (our current application host).
This is a shortcoming of AWS Cloudformation and available options
for AWS ECS
ValueFromfield.Solution:
Instead of trying to parse the secrets manager entry and pick specific
parameters in the CloudFormation template, we do the parsing in
config.py and pass the whole JSON stored in secrets manager.
This is agnostic of AWS and can be extended to any cloud provider or
server host in the future.