Remove redundant TeamsRestAPI Post method #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-rita
force-pushed
the
fix/teams-post-method
branch
from
296f69a
to
3bd4867
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
eternaltyro
approved these changes
Apr 16, 2023
There might be no need to change the API version since the method itself was not in use at any point, i.e. not mapped to any endpoint. |
|
Okay, that does not warrant an API version change. All clear from my end. |
Aadesh-Baral
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Under the TeamsRestAPI, we have two methods doing the same job, i.e. POST and PATCH. This PR removes the redundant POST method that is not in use anywhere and is essentially a copy of what the PATCH method does.
The PATCH method is retained since the RFC standards dictate that the PATCH method is what is used to update a resource and not POST.