Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comments Module API Tests #5641

Merged
merged 1 commit into from Mar 27, 2023
Merged

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Mar 22, 2023

This PR handles the Comments module-related API endpoint tests.

How to test:

  • create a test database following the instructions here. The database name is preceded by test_
  • pull and checkout test branch using git fetch origin && git checkout chore/add-comments-tests
  • run tests using python3 -m unittest discover tests/backend

@d-rita d-rita marked this pull request as ready for review March 22, 2023 13:30
@tsmock
Copy link
Contributor

tsmock commented Mar 22, 2023

Can you add an __init__.py file to the new test directory?

Almost every test directory has one (the only ones that don't were added in the past year).

You might be wondering why. nose (which is what the TM CI uses to run tests) hasn't been updated since 2016, and completely fails to run on recent python versions. I'm currently working on updating pretty much all of the dependencies for the TM (see #5642), and I'm using pytest instead of nose. I would anticipate nose2 having the same problem. And nose2 recommends pytest over itself as well.

@d-rita d-rita mentioned this pull request Mar 22, 2023
17 tasks
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Aadesh-Baral Aadesh-Baral merged commit a8e0431 into develop Mar 27, 2023
3 checks passed
@Aadesh-Baral Aadesh-Baral deleted the chore/add-comments-tests branch March 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants