Update tests for notifications page and its components (Part 1/2) #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of rendering the login page from the same component
Replaces the use of fetchLocalJSONAPI with custom hook useFetchWithAbort aiming for a cleaner component
- Message Avatar - should return nothing username and message type is undefined - should return system generated display picture if username is not passed - Notification Card - should mark the notification as read - should delete the notification - should catch error on deletion error - should open any links in the notification message - should open notification modal - Notification Card Mini - should refetch notifications on closing the dialog
- Notifications Page - should navigate to the login page if the user is not logged in - should display notifications if the user is logged in - Mini Notification Results - should display the refresh button - should display no notifications found message - Notifications Results - should display error message for fetching notifications - should fetch for notifications on clicking the try again button - should display no notifications found message
Accidentally used errorLoadingNotifications for projects search results page. Reverting that.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.