Hide private teams on organisation detail view for users without manage permission #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manager. ------------------------- Add a condition to filter out teams based on visibility on the function to return organization dto, such that private projects are only returned for users with organisation manage permissions.
--------------------------- The test code for the get_organisation_stats function passed the year parameter as "None" in the test case. A code scanning alert was raised because the year argument expects an integer in this method.
|
Kudos, SonarCloud Quality Gate passed!
|
d-rita
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5723
What to test?
Private teams should be hidden on the organization detail page if any of the following conditions are met:
Private teams should be displayed on the organization detail page if any of the following conditions are met:
Public teams should be visible under all circumstances.