Remove unreachable condition to raise organisation NotFound #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------------------------------- The condtion to raise NotFound was unreachable as the function to return org already would have raised the NotFound exception if org was returned None.
--------------------------------------- In the previous implementation a non reachable condition was present that raised NotFound is org was none. As we were mocking the function to return the org as None it was reachable on test case. This commits updates the test case to reflect that change.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condtion to raise NotFound was unreachable as the function to return org already would have raised the NotFound exception if org was returned None. This PR removes that condition and updates the test case reflecting the change.