Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use keys for comments from taskIds #5765

Merged
merged 1 commit into from
May 9, 2023
Merged

Use keys for comments from taskIds #5765

merged 1 commit into from
May 9, 2023

Conversation

HelNershingThapa
Copy link
Contributor

closes #5574. hopefully

@HelNershingThapa
Use keys for comments from taskIds
4f6548f 
The change involves updating the key prop in the ItemComponent from using the index n to using the taskId property of the item.properties. This is a better approach because using the index can cause issues with component re-rendering and can result in errors or inconsistencies.
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ichchhie Ichchhie merged commit 3e3332c into develop May 9, 2023
5 checks passed
@Ichchhie Ichchhie deleted the fix/5574-comments-identifier-keys branch May 9, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ichchhie Ichchhie Ichchhie approved these changes

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task comment screen vanishes while writing a comment
2 participants
@HelNershingThapa @Ichchhie