Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Transifex #5822

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Update Transifex #5822

merged 1 commit into from
Aug 16, 2023

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented May 22, 2023

What does this PR do?

Steps taken:

  • installed new client built with Go
  • run tx migrate to update the config file
  • updated link in the contributing translations section of the documentation

How to test:

  • install the new Transifex client
  • run tx commands, e.g tx push -s to push the source file to the Transifex repo or tx pull -af --mode translator to pull all translated language changes to the TM project. The translation files live in the frontend/src/locales folder.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@HelNershingThapa
Copy link
Contributor

@d-rita The localization files found in frontend/src/locales won't be updated with the most recent Transifex translations as part of this PR, will it?

@HelNershingThapa
Copy link
Contributor

Is this PR related to #5072?

Copy link
Contributor

@eternaltyro eternaltyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@d-rita
Copy link
Contributor Author

d-rita commented Jun 12, 2023

The localization files found in frontend/src/locales won't be updated with the most recent Transifex translations as part of this PR, will it?

@HelNershingThapa this PR only updates the tx/config file. In order to update the localisation files, we'd have to first pull the translated strings from the Transifex repo. And we have not done that yet.

@d-rita
Copy link
Contributor Author

d-rita commented Jun 12, 2023

Is this PR related to #5072?

Yes. Was not aware of this PR but it updates the config file and localisation files as well. cc: @dakotabenjamin

@HelNershingThapa
Copy link
Contributor

@HelNershingThapa this PR only updates the tx/config file. In order to update the localisation files, we'd have to first pull the translated strings from the Transifex repo. And we have not done that yet.

Will that be a part of this PR?

@d-rita
Copy link
Contributor Author

d-rita commented Jun 12, 2023

That is to be determined. The last time we had discussed this issue we had talked about creating a PR to update translations before the next release. Whether it is with this PR or another, we'd have to agree. cc: @Ichchhie @ramyaragupathy

@dakotabenjamin
Copy link
Member

After some thought, I have come around that we should merge this now and add translations in a new pull request.

@dakotabenjamin dakotabenjamin merged commit cb6990c into develop Aug 16, 2023
8 checks passed
@Aadesh-Baral Aadesh-Baral deleted the chore/update-transifex branch August 16, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Transifex
4 participants