Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HOT specific default variable values #5849

Merged
merged 1 commit into from
May 30, 2023

Conversation

eternaltyro
Copy link
Contributor

Add default values in Frontend index.js that is specific to HOT Tasking Manager. This will make deployments easier by reducing the number of variables HOT needs to include.

Add default values in Frontend index.js that is specific to HOT Tasking
Manager. This will make deployments easier by reducing the number of
variables HOT needs to include.
@eternaltyro eternaltyro added type: enhancement Improving an existing functionality scope: frontend labels May 30, 2023
@eternaltyro eternaltyro self-assigned this May 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@HelNershingThapa HelNershingThapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

export const ORG_GITHUB = process.env.REACT_APP_ORG_GITHUB || '';
export const ORG_TWITTER = process.env.REACT_APP_ORG_TWITTER || 'https://twitter.com/hotosm';
export const ORG_FB = process.env.REACT_APP_ORG_FB || 'https://www.facebook.com/hotosm';
export const ORG_INSTAGRAM = process.env.REACT_APP_ORG_INSTAGRAM || 'https://www.instagram.com/open.mapping.hubs/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link seems broken?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the Instagram link of the main instance is also broken.

@HelNershingThapa HelNershingThapa merged commit a387b3e into develop May 30, 2023
8 checks passed
@HelNershingThapa HelNershingThapa deleted the enhance/add-frontend-defaults branch May 30, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: frontend type: enhancement Improving an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants