Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add missing await for async statements in tests #5871

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jun 2, 2023

  • waitFor
  • userEvent
  • clearReduxStore

Note: act not done since it is only async in newer versions of jest.

* `act`
* `waitFor`
* `userEvent`
* `clearReduxStore`

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@HelNershingThapa HelNershingThapa merged commit 3af8c74 into hotosm:develop Jun 7, 2023
6 of 7 checks passed
@tsmock tsmock deleted the chore/add-missing-await branch June 7, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants