Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all of the transitive dependencies from requirements.txt #5876

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

Aadesh-Baral
Copy link
Contributor

@Aadesh-Baral Aadesh-Baral commented Jun 5, 2023

This PR does the following:

  • Remove all of the transitive dependencies from requirements.txt as they are handled in pdm.lock and we only use requirements.txt to get dependency updates from dependabot.
  • Reorder dependencies in pyproject.toml since pandas and scikit-learn were listed under section "dependencies used by HOT for production".

----------------------------------------
As we use requirements.txt only to receive dependency updates from dependabot, and transitive dependencies in requirements.txt cause dependabot to generate a PR for them as well.
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Aadesh-Baral Aadesh-Baral merged commit 51b11e1 into develop Jun 5, 2023
8 checks passed
@Aadesh-Baral Aadesh-Baral deleted the dev/remove-transitive-dependencies branch June 5, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant