Update tests for the notifications page components #5885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue preventing an uncaught error when routing to a location using `Link`
he `generateSampleNotifications` function is added, which takes the number of samples as a parameter and generates an array of sample notification objects.
to eliminate prop drilling and improve code organization maybe.
Will now show error loading notification instead of error loading message
… function since the dropdown selection is single select?
the previous commits I'm taking about here being the use of function to generate n number of notifications and removal of updateUnreadCount as props to ActionButtons
…ions on the last page
HelNershingThapa
force-pushed
the
tests/5722-notifications-page
branch
from
4398e7c
to
a64180f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
d-rita
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5722
This pull request primarily focuses on updating component tests on the notifications page. Additionally, it includes several other improvements unrelated to the test code. Here is a summary of the changes:
setPoputFocusto theInboxNavMinicomponent, preventing an uncaught error when routing to a location using Link.generateSampleNotificationsfunction to simplify testing interactions with all notifications on a page./notifications/:idendpoint.updateUnreadCountfunction to theActionButtonscomponent to eliminate prop drilling and improve code organization.elseconditional statements from theonSortSelectfunction since the dropdown selection is single select.