Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactJS: Fix an input component changing from uncontrolled to controlled #5890

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jun 7, 2023

This is due to the "initial" value being undefined or null prior to the user data being fetched.

This is due to the "initial" value being `undefined` or `null` prior to
the user data being fetched.

Signed-off-by: Taylor Smock <tsmock@meta.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

Copy link
Contributor

@HelNershingThapa HelNershingThapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your efforts in addressing those warnings and ensuring the inputs are controlled

@HelNershingThapa HelNershingThapa merged commit f65fc5e into hotosm:develop Jun 22, 2023
3 checks passed
@tsmock tsmock deleted the chore/fix-input-component-changing-from-uncontrolled-to-controlled branch June 22, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants