Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @babel/plugin-proposal-private-property-in-object to devDependencies #5948

Conversation

HelNershingThapa
Copy link
Contributor

Ran into the following issue.

One of your dependencies, babel-preset-react-app, is importing the "@babel/plugin-proposal-private-property-in-object" package without declaring it in its dependencies. This is currently working because "@babel/plugin-proposal-private-property-in-object" is already in your node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which is not maintianed anymore. It is thus unlikely that this bug will ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to your devDependencies to work around this error. This will make this message go away.

This PR is the workaround to make the message go away.

Ran into this.
"One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away."
@github-actions github-actions bot added scope: frontend dependencies Pull requests that update a dependency file javascript labels Jun 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HelNershingThapa HelNershingThapa merged commit 55786d2 into develop Jun 27, 2023
8 checks passed
@HelNershingThapa HelNershingThapa deleted the workaround/@babel/plugin-proposal-private-property-in-object branch June 27, 2023 07:39
@tsmock
Copy link
Contributor

tsmock commented Jul 5, 2023

Fair enough. I didn't do this in #5937 since it was fixed in react-scripts, and I was really hoping that they would do a release ASAP to fix it. Realistically we'll probably want to move off of CRA once we are on Node 18 and have a (relatively) stable and up-to-date base to work off of.

@HelNershingThapa
Copy link
Contributor Author

Had they done the release, it'd have been a more convenient solution for us.

Realistically we'll probably want to move off of CRA once we are on Node 18

Next or Vite maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants