Enable ability for users to select tasks they mapped #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Per chat w/ @HelNershingThapa and @Aadesh-Baral following are the next steps:
|
- Emend popup text to "This task was mapped by you" - Remove the not-allowed cursor implementation
- Enhances the `LockError` modal by introducing a "Deselect and Continue" button. The button is displayed when a `CannotValidateMappedTask` task lock error occurs. The "Close" button is shown with the primary variant when only a single task is selected. - Conditionally displayed the buttons based on the user's selected tasks and mapping status. - Separated the action buttons into a new component named `LockErrorButtons`. - Moved the logic for handling task deselection and validation into the `LockErrorButtons` component. - Updated the existing test cases to reflect the new changes made in the `LockErrorButtons` component.
HelNershingThapa
force-pushed
the
enhancement/5435-click-mapped-task
branch
from
9d42fc7
to
f1f1acd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
For now, we are not including task numbers in the pop-up and keep the message minimal. This can be later added if the users find it beneficial. |
emi420
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5435
Changes Made
LockErrorButtonscomponent, which also handles task deselection and validation logic.