Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactJS: Don't use 'selected' for '<option/>' nodes #5965

Merged
merged 1 commit into from
Jul 7, 2023
Merged

ReactJS: Don't use 'selected' for '<option/>' nodes #5965

merged 1 commit into from
Jul 7, 2023

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jul 6, 2023 •
edited

This makes the language selection box down a controlled selection box.

@tsmock
ReactJS: Don't use 'selected' for '<option/>' nodes
dbfc0d3 
Signed-off-by: Taylor Smock <tsmock@meta.com>
@tsmock tsmock mentioned this pull request Jul 6, 2023
Merged
@tsmock tsmock marked this pull request as ready for review July 6, 2023 17:35
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@HelNershingThapa HelNershingThapa merged commit f84fa3a into hotosm:develop Jul 7, 2023
7 checks passed
@tsmock tsmock deleted the fixup/option-nodes-dont-use-select branch July 7, 2023 09:39
HelNershingThapa pushed a commit that referenced this pull request Jul 7, 2023
@tsmock @HelNershingThapa
ReactJS: Don't use 'selected' for '<option/>' nodes (#5965)
030518f 
Signed-off-by: Taylor Smock <tsmock@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelNershingThapa HelNershingThapa HelNershingThapa approved these changes

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsmock @HelNershingThapa