Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GPX name attribute string translatable #5985

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Make GPX name attribute string translatable #5985

merged 1 commit into from
Jul 18, 2023

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Jul 16, 2023

Fixes #5650

@d-rita d-rita force-pushed the fix/gpx-name-attribute branch 3 times, most recently from 30bf0dd to 6011ed7 Compare July 17, 2023 18:43
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

HelNershingThapa
HelNershingThapa approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@HelNershingThapa HelNershingThapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally; translated strings appear. LGTM.

@HelNershingThapa HelNershingThapa merged commit 795d23d into develop Jul 18, 2023
8 checks passed
@HelNershingThapa HelNershingThapa deleted the fix/gpx-name-attribute branch July 18, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelNershingThapa HelNershingThapa HelNershingThapa approved these changes

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPX name attribute cannot be translated
2 participants
@d-rita @HelNershingThapa