Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ohsome envvar infra #6421

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix/ohsome envvar infra #6421

merged 2 commits into from
May 13, 2024

Conversation

dakotabenjamin
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

Fixes an issue related to the contributions failing to load. The ohsome api token was not being set in the backend servers.

Screenshots

image

Alternative Approaches Considered

No

Review Guide

If this deploys properly on the dev server, I will also push it to main as per the git flow model we follow. Then we can make a hotfix release from main for next week.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

gif

@dakotabenjamin
Copy link
Member Author

dakotabenjamin commented May 9, 2024

hm, I'm not sure why there are additional commits here.

edit: Its because I was working off of main. Anyone have suggestions for how I should be handling this better in git?
edit2: fixed from #6422

@dakotabenjamin dakotabenjamin changed the base branch from develop to main May 9, 2024 17:28
@dakotabenjamin dakotabenjamin changed the base branch from main to develop May 9, 2024 17:29
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ramyaragupathy ramyaragupathy merged commit 9b3fe34 into develop May 13, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants