Fix ubuntu deployment #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying to heroku or running on travis, I was seeing:
You are trying to install in deployment mode after changing
your Gemfile. Run `bundle install` elsewhere and add the
updated Gemfile.lock to version control.
You have added to the Gemfile:
* therubyracer (~> 0.11.3)
I assume because of the conditional we had for platform. Sooo let's take
that out.
Somehow the polyglot lines got duplicated a whole bunch in the Gemfile.lock????
carols10cents
force-pushed
the
fix-ubuntu-deployment
branch
from
60b46a1
to
0ef9cae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying to heroku or running on travis, I was seeing:
I assume because of the conditional we had for platform. Sooo let's take that out.
This also includes a commit to fix a bunch of duplicated lines in the Gemfile.lock that I didn't see in the commit of wilkie's i just merged because github assumes you don't want to see the Gemfile.lock diff :P