Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch ruleActions and ruleConditions while fetching list of rules for a rule Group instead of fetching individually for each rule. #299

Closed
3 tasks
amansinghbais opened this issue May 8, 2024 · 0 comments
Closed
3 tasks

Fetch ruleActions and ruleConditions while fetching list of rules for a rule Group instead of fetching individually for each rule. #299

amansinghbais opened this issue May 8, 2024 · 0 comments
Labels
enhancement New feature or request release-v3.0.0

Comments

@amansinghbais
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently we fetch list of all the rules in a ruleGroup and then individually fetch ruleActions and ruleConditions for each rule. Instead of doing so use a endpoint to fetch all rules ruleConditions and ruleActions at the time of fetching rules.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@amansinghbais amansinghbais self-assigned this May 8, 2024
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue May 8, 2024
@amansinghbais
Improved: logic to fetch ruleActions and ruleConditions while fetchin…
5d2f524 
…g the rules for a group (hotwax#299)
@amansinghbais amansinghbais mentioned this issue May 8, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue May 8, 2024
@amansinghbais
Fixed: added missing / form the baseUrl check while login (hotwax#299)
46c4895
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue May 8, 2024
@amansinghbais
Improved: set multivalued to always 'Y' and fetching ruleGroup with a…
a9b94cf 
…ctive status (hotwax#299)
ravilodhi added a commit that referenced this issue May 8, 2024
@ravilodhi
Merge pull request #300 from amansinghbais/299-rule-fetching-logic
80a305d 
Improved: logic to fetch ruleActions and ruleConditions while fetching the rules for a group (#299)
@Adameddy26 Adameddy26 added enhancement New feature or request release-v3.0.0 labels Jun 3, 2024
@amansinghbais amansinghbais removed their assignment Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request release-v3.0.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amansinghbais @Adameddy26