Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantity should not be prefilled with 0 as causing server error #232

Closed
2 tasks
adityasharma7 opened this issue May 31, 2023 · 0 comments · Fixed by #234
Closed
2 tasks

Quantity should not be prefilled with 0 as causing server error #232

adityasharma7 opened this issue May 31, 2023 · 0 comments · Fixed by #234
Assignees
@adityasharma7
Labels
bug Something isn't working

Comments

@adityasharma7
Copy link
Contributor

Current behavior

When the quantity is prefilled with 0 and the user has not received the item, the quantity is passed is 0 causing action failure:
Both quantity to accept and quantity to reject cannot be zero.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@adityasharma7 adityasharma7 added the bug Something isn't working label May 31, 2023
alsoK2maan pushed a commit to alsoK2maan/receiving that referenced this issue Jun 14, 2023
@k2maan
Fixed: server error when zero as quantity is passed (hotwax#232)
701aa0e
@alsoK2maan alsoK2maan mentioned this issue Jun 14, 2023
Merged
1 task
alsoK2maan pushed a commit to alsoK2maan/receiving that referenced this issue Jun 16, 2023
@k2maan
Improved: naming for checking eligibility (hotwax#232)
4822c67
adityasharma7 added a commit that referenced this issue Jun 16, 2023
@adityasharma7
Merge pull request #234 from k2maan/#232
4da36cf 
Fixed: server error when zero as quantity is passed (#232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityasharma7 adityasharma7

Labels
bug Something isn't working
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: server error when zero as quantity is passed (#232) alsoK2maan/receiving
2 participants
@adityasharma7 @alsoK2maan