Fire Value Change Callbacks consistently #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Closes 490][] According to the [Change callbacks][] documentation: > Stimulus invokes each change callback after the controller is > initialized and again any time its associated data attribute changes. > This includes changes as a result of assignment to the value’s setter. Prior to this change, this was true for all value change callbacks _except_ for those that declare defaults. This change moves the `ValueObserver.invokeChangedCallbacksForDefaultValues()` invocation out of the constructor and into the `ValueObserver.start()` call, which is invoked by [Context.connect][], which is invoked _after_ the [Context.constructor][]. [Closes 490]: hotwired#490 [Change callbacks]: https://stimulus.hotwired.dev/reference/values#change-callbacks [Context.constructor]: https://github.com/hotwired/stimulus/blob/5149adf287425597306d7871b1820795d7af1e66/src/core/context.ts#L20-L34 [Context.connect]: https://github.com/hotwired/stimulus/blob/5149adf287425597306d7871b1820795d7af1e66/src/core/context.ts#L36-L47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 490
According to the Change callbacks documentation:
Prior to this change, this was true for all value change callbacks
except for those that declare defaults.
This change moves the
ValueObserver.invokeChangedCallbacksForDefaultValues()invocation outof the constructor and into the
ValueObserver.start()call, which isinvoked by Context.connect, which is invoked after the
Context.constructor.