log_controller_test_case: Fix deepEqual returning true for primitive types #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
deepEqual
to return the correct value when comparing primitive types.When comparing
obj1
andobj2
,deepEqual
first performs a standard===
check. If that fails, it then proceeds to do a "deep comparison" with each targets' properties. However, sinceObject.keys(obj)
always returns an empty array for primitive types, this means thatdeepEqual
will always returntrue
when comparing primitives as there are no properties to compare. (For example,deepEqual(true, false)
will result intrue
.)To avoid this, we only perform the deep comparison if both targets are of type
object
. If they are not, we returnfalse
.Fixes #532.