Only show error screens for SSL errors when the url matches the curre…

…nt visit. This prevents erroring out the entire visit when a 3rd party resource is requested on a page with an SSL error.
hotwired · Mar 20, 2024 · 3bf26ca · 3bf26ca
1 parent e0176f8
commit 3bf26ca
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/turbo/src/main/kotlin/dev/hotwire/turbo/session/TurboSession.kt b/turbo/src/main/kotlin/dev/hotwire/turbo/session/TurboSession.kt
@@ -783,10 +783,12 @@ class TurboSession internal constructor(
             handler.cancel()
 
             val visitError = WebSslError.from(error)
+            logEvent("onReceivedSslError", "error" to visitError, "url" to error.url)
 
-            logEvent("onReceivedSslError", "error" to visitError)
-            reset()
-            callback { it.onReceivedError(visitError) }
+            if (currentVisit?.location == error.url) {
+                reset()
+                callback { it.onReceivedError(visitError) }
+            }
         }
 
         override fun onRenderProcessGone(view: WebView, detail: RenderProcessGoneDetail): Boolean {