Fix WebView scrolling in BottomSheet #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Mar 14, 2023
| @@ -6,15 +6,16 @@ | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent"> | |||
|
|
|||
| <FrameLayout | |||
| <androidx.core.widget.NestedScrollView | |||
There was a problem hiding this comment.
WebView hasn't always played nicely with NestedScrollView, but maybe that's been resolved over the last couple years. We'll want to test this thoroughly. Can you make sure that we're using the latest androidx dependency?
There was a problem hiding this comment.
There don't seem to be any issues with this anymore 🤞
I updated all the dependencies in a separate PR (#262) and there don't seem to be any issues.
jayohms
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the layout of
TurboWebBottomSheetDialogFragmentto enable nested scrolling of aWebViewinBottomSheet.