Fix refresh control positioning #123
Conversation
svara
changed the title
svara
changed the title
|
@spinosa @ghiculescu @joemasilotti @Bramjetten I saw you guys were involved in the related PR (#73). |
|
|
||
| /// Infer refresh control's default height from its frame, if given. | ||
| /// Otherwise fallback to 60 (the default height). | ||
| let refreshControlHeight = refreshControl.frame.height > 0 ? refreshControl.frame.height : 60 | ||
|
|
There was a problem hiding this comment.
Why do we have to specify the height?
Internally, refresh control doesn't use autolayout for positioning its subviews. Its main frame doesn't reflect its true size. The main container height is 60pt, but the view where the refresh image/animation is has a height of 100pt. When using autolayout the latter is used. 🤷♂️ Even if we don't set the height, the refresh control will respect the safe area, but it won't be positioned as it should be.
| NSLayoutConstraint.activate([ | ||
| refreshControl.centerXAnchor.constraint(equalTo: centerXAnchor), | ||
| refreshControl.topAnchor.constraint(equalTo: safeAreaLayoutGuide.topAnchor), | ||
| refreshControl.heightAnchor.constraint(equalToConstant: refreshControlHeight) | ||
| ]) |
There was a problem hiding this comment.
Using autolayout ensures the system takes care of updating the view's position as appropriate.
centerXAnchor makes sure the control is always centered with the view’s horizontal center.
Pinning control's top anchor to the view's safe area top anchor ensures the control is positioned within the safe area.
Thanks for this! Will try it out in our apps next week and report back 👍 |
|
I have just tested and confirmed it works in my project! Thanks, this is much appreciated! |
|
That's great to hear @Bramjetten! Thanks! |
Summary
This PR fixes refresh control's positioning by using constraints.
Context
UIRefreshControlis a critical component that enables users to refresh content by pulling down on a scroll view.The conventional approach involves assigning the
UIRefreshControldirectly to the web view's scroll view. However, in a specific case (usingviewport-fit=cover), this approach did not provide the desired functionality. See #73.Solution
To address this issue, we have updated the
UIRefreshControlpositioning by utilizing constraints. With this approach, we can ensure theUIRefreshControladjusts properly within the safe area.