Webview fixes

[spinosa]

• Fix Swift compiler warning about PathConfigurationDelegate being a class by making it AnyObject
• When activating the webview, insert at index 0 so the containing UINavigationController locates its scrollview and correctly handles scrolling related behavior (ex: navigation bar translucency)
• Install UIRefreshControl on the .refreshControl property of the web view's scroll view
• Add documentation about viewport-fit=cover affecting the position of the UIRefreshControl

[ghiculescu]

Do you have a screenshot for this issue?

We set the viewport to width=device-width,initial-scale=1,maximum-scale=1,viewport-fit=cover and haven't noticed this issue.

[spinosa]

There could be confounders at play. Would need to repro on a minimal app. But here are screenshots of our app (deployment target 14.0, running on 15.4.1) where the only difference is the inclusion of viewport-fit=cover:

Without viewport-fit=cover:

With viewport-fit=cover:

[ghiculescu]

Ahh you're right ours does that too, now I look at it. I was always like 🤷 that's high up but whatever.

[tabuna]

I faced the same issue. On a project without specifying cover:

But with indication, it looks like this (the slider is almost invisible due to the white bar):

Is there any way to get the correct display from the viewport cover?

[connorbey13]

This fixed my issue with content showing in the nav bar and status bar. 👍

[JoshAntBrown]

This fixed the same translucency issue around nav, status and tab bars but broke the pull down to dismiss modal interaction because the refresh control took over. Ended up creating a fork and creating a branch with just the change to insert the webview fixing the translucency issue.

[joemasilotti]

Fix Swift compiler warning about PathConfigurationDelegate being a class by making it AnyObject

Nice, thanks for that!

When activating the webview, insert at index 0 so the containing UINavigationController locates its scrollview and correctly handles scrolling related behavior (ex: navigation bar translucency)

Install UIRefreshControl on the .refreshControl property of the web view's scroll view

Good call. @jayohms, is there any history as to why this wasn't done to begin with? We aren't introducing any weird edge cases?

Add documentation about viewport-fit=cover affecting the position of the UIRefreshControl

Confirmed that this fixes a lot of issues I've seen folks mention. In the second screenshot I'm pulling down to refresh and the spinner is in the correct position.

viewport-fit=cover	(removed)

[Bramjetten]

How are you people handling the viewport-fit=cover bug? Without viewport-fit=cover, all of my pages are longer than the screen resulting in an unnecessary scroll area. Adding viewport-fit=cover fixes that, but it introduces this bug with the refreshControl.

[svara]

This has been fixed in #123.