Expose web view activation/deactivation in Visitable #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svara
commented
Aug 4, 2023
svara
commented
Aug 4, 2023
…ation in the protocol extension.
jayohms
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
@svara once the tests pass, you can merge this over and tag a new release.
You may have to bump this timeout for the failing tests when turbo doesn't exist on a page: https://github.com/hotwired/turbo-ios/blob/main/Tests/SessionSpec.swift#L8 (or just use a separate timeout constant for the failing test from the changes here: #133)
…ation also in `VisitableViewController`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes web view activation/deactivation in
Visitable.The main reason we are exposing them is because we need to delegate the web view activation/deactivation to
Strada.