Add Type Safety Guards to turbo/fetch_requests
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
fetch-request-improvements
branch
2 times, most recently
from
c804ecd
to
6d87887
Compare
|
cc: @dhh |
seanpdoyle
force-pushed
the
fetch-request-improvements
branch
7 times, most recently
from
20001fd
to
567edd3
Compare
Without this change, GET `<form>` submissions without a Fetch Options `{
body: }` raise the following:
```
Uncaught TypeError: s.body is null
<anonymous> fetch_requests.js:10
w turbo.es2017-esm.js:351
requestStarted turbo.es2017-esm.js:770
perform turbo.es2017-esm.js:520
start turbo.es2017-esm.js:744
formSubmitted turbo.es2017-esm.js:3369
```
Through the exercise of attempting to [port the `turbo/fetch_requests`
module to
TypeScript](hotwired#392 (comment)),
we've identified some potential edge cases in the algorithm that
determines a request's HTTP method.
Even if the migration to TypeScript doesn't come to fruition for some
time, those edge cases should be addressed sooner rather than later.
This commit adds more "type safety" motivated conditionals and guards to
make sure that values are present before overriding them.
seanpdoyle
force-pushed
the
fetch-request-improvements
branch
6 times, most recently
from
27d4e14
to
efe8f43
Compare
Replace looping mechanisms with Capybara assertion for the presence of a `<turbo-cable-stream-source>` element.
seanpdoyle
force-pushed
the
fetch-request-improvements
branch
from
efe8f43
to
2e38b70
Compare
|
(edit) I was commenting in the wrong place 😅 Moved to here: #392 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, GET
<form>submissions without a Fetch Options{ body: }raise the following:Through the exercise of attempting to port the
turbo/fetch_requestsmodule toTypeScript, we've identified some potential edge cases in the algorithm that determines a request's HTTP method.
Even if the migration to TypeScript doesn't come to fruition for some time, those edge cases should be addressed sooner rather than later.
This commit adds more "type safety" motivated conditionals and guards to make sure that values are present before overriding them.