Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple string arguments to frame helper #504

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Oct 16, 2023

This fixes a regression in 1.5.0

Fixes #503

@jcoyne jcoyne force-pushed the restore-dom branch 2 times, most recently from f26b571 to ffcbafc Compare October 16, 2023 13:05
jcoyne added a commit to sul-dlss/library_hours_rails that referenced this pull request Oct 16, 2023
We can unpin when hotwired/turbo-rails#504 is merged and released
@@ -36,7 +36,7 @@ module Turbo::FramesHelper
# <%= turbo_frame_tag(Article.find(1), Comment.new) %>
# # => <turbo-frame id="article_1_new_comment"></turbo-frame>
def turbo_frame_tag(*ids, src: nil, target: nil, **attributes, &block)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've pulled your example in.

@jcoyne
Copy link
Contributor Author

jcoyne commented Oct 16, 2023

@seanpdoyle it looks like one of the tests is timing out and I don't have the permissions to restart it.

@seanpdoyle
Copy link
Contributor

I don't have permissions either. If you rebase the commit and force push, it'll run again

@jcoyne
Copy link
Contributor Author

jcoyne commented Oct 16, 2023

@afcapel are you able to restart that one build?

@dhh dhh merged commit 818d919 into hotwired:main Oct 17, 2023
10 of 11 checks passed
@jcoyne jcoyne deleted the restore-dom branch October 17, 2023 15:28
@swanson
Copy link
Contributor

swanson commented Nov 2, 2023

Thank you! Ran into this as well when upgrading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

turbo_frame_tag with arrary argument regression
4 participants