Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten and compact *streamables arguments #615

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

seanpdoyle
Copy link
Contributor

@seanpdoyle seanpdoyle commented Apr 12, 2024

Closes #528
Closes #614

When broadcasting, ignore "" and nil values, especially when they are the only values when generating the streamable channel name and content.

@ConfusedVorlon
Copy link

Thank You :)

Closes [hotwired#614][]

When broadcasting, ignore `""` and `nil` values, especially when they
are the only values when generating the streamable channel name and
content.

[hotwired#614]: hotwired#614
@ConfusedVorlon
Copy link

Is it normal for pull requests to sit this long?

@brunoprietog
Copy link
Contributor

Thanks @seanpdoyle!

/cc @jorgemanrubia

@brunoprietog brunoprietog merged commit c30f7d9 into hotwired:main Jun 21, 2024
15 checks passed
@seanpdoyle seanpdoyle deleted the issue-614 branch June 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't broadcast refresh if streamables == [nil]
3 participants