fix types with optional arguments

src/core/frames/frame_controller.ts

@@ -52,7 +52,7 @@ export class FrameController
   private ignoredAttributes: Set<FrameElementObservedAttribute> = new Set()
   private action: Action | null = null
   private frame?: FrameElement
-  private resolveInterceptionPromise = (_value: any) => {}
+  private resolveInterceptionPromise = (_value?: any) => {}
   readonly restorationIdentifier: string
 
   constructor(element: FrameElement) {

src/core/view.ts

@@ -23,7 +23,7 @@ export abstract class View<
   abstract readonly snapshot: S
   renderPromise?: Promise<void>
   private resolveRenderPromise = (_value: any) => {}
-  private resolveInterceptionPromise = (_value: any) => {}
+  private resolveInterceptionPromise = (_value?: any) => {}
 
   constructor(delegate: D, element: E) {
     this.delegate = delegate

src/globals.d.ts

@@ -3,20 +3,6 @@ import { ReloadReason } from "./core/native/browser_adapter"
 import { TimingData } from "./core/session"
 import { FetchResponse } from "./http/fetch_response"
 
-interface SubmitEvent extends Event {
-  submitter: HTMLElement | null
-}
-
-interface Node {
-  // https://github.com/Microsoft/TypeScript/issues/283
-  cloneNode(deep?: boolean): this
-}
-
-interface Window {
-  Turbo: typeof import("./core/index")
-  SubmitEvent: typeof Event
-}
-
 interface CustomEventMap {
   "turbo:click": TurboClickEvent
   "turbo:before-visit": TurboBeforeVisitEvent
@@ -40,12 +26,12 @@ declare global {
   type TurboBeforeVisitEvent = CustomEvent<{ url: string }>
   type TurboVisitEvent = CustomEvent<{ url: string; action: Action }>
   type TurboBeforeCacheEvent = CustomEvent
-  type TurboBeforeRenderEvent = CustomEvent<{ newBody: HTMLBodyElement; resume: (value: any) => void }>
+  type TurboBeforeRenderEvent = CustomEvent<{ newBody: HTMLBodyElement; resume: (value?: any) => void }>
   type TurboRenderEvent = CustomEvent
   type TurboLoadEvent = CustomEvent<{ url: string; timing: TimingData }>
   type TurboFrameLoadEvent = CustomEvent
   type TurboFrameRenderEvent = CustomEvent<{ fetchResponse: FetchResponse }>
-  type TurboBeforeFrameRenderEvent = CustomEvent<{ fetchResponse: FetchResponse; resume: (value: any) => void }>
+  type TurboBeforeFrameRenderEvent = CustomEvent<{ fetchResponse: FetchResponse; resume: (value?: any) => void }>
   type TurboSubmitStartEvent = CustomEvent<{ formSubmission: FormSubmission }>
   type TurboSubmitEndEvent = CustomEvent<{
     formSubmission: FormSubmission
@@ -54,12 +40,12 @@ declare global {
     error?: Error
   }>
   type TurboReloadEvent = CustomEvent<{ reason: ReloadReason }>
-  type TurboBeforeFetchRequestEvent = CustomEvent<{ fetchResponse: FetchResponse }>
-  type TurboBeforeFetchResponseEvent = CustomEvent<{
+  type TurboBeforeFetchRequestEvent = CustomEvent<{
     fetchOptions: RequestInit
     url: URL
-    resume: (value: any) => void
+    resume: (value?: any) => void
   }>
+  type TurboBeforeFetchResponseEvent = CustomEvent<{ fetchResponse: FetchResponse }>
 
   interface Document {
     //adds definition to Document, but you can do the same with HTMLElement
@@ -68,6 +54,20 @@ declare global {
       listener: (this: Document, ev: CustomEventMap[K]) => void
     ): void
   }
+
+  interface SubmitEvent extends Event {
+    submitter: HTMLElement | null
+  }
+
+  interface Node {
+    // https://github.com/Microsoft/TypeScript/issues/283
+    cloneNode(deep?: boolean): this
+  }
+
+  interface Window {
+    Turbo: typeof import("./core/index")
+    SubmitEvent: typeof Event
+  }
 }
 
 export {}

src/http/fetch_request.ts

@@ -55,7 +55,7 @@ export class FetchRequest {
   readonly body?: FetchRequestBody
   readonly target?: FrameElement | HTMLFormElement | null
   readonly abortController = new AbortController()
-  private resolveRequestPromise = (_value: any) => {}
+  private resolveRequestPromise = (_value?: any) => {}
 
   constructor(
     delegate: FetchRequestDelegate,

src/tests/functional/frame_navigation_tests.ts

@@ -27,7 +27,7 @@ export class FrameNavigationTests extends TurboDriveTestCase {
     await this.goToLocation("/src/tests/fixtures/tabs.html")
 
     this.remote.execute(() => {
-      addEventListener("turbo:before-frame-render", () => {
+      document.addEventListener("turbo:before-frame-render", () => {
         localStorage.setItem("beforeRenderUrl", window.location.pathname)
         localStorage.setItem("beforeRenderContent", document.querySelector("#tab-content")?.textContent || "")
       })