-
Notifications
You must be signed in to change notification settings - Fork 412
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Problem --- Consider a `<turbo-frame>` element with `loading="lazy"`. Once it becomes visible, the `AppearanceObserver` will delegate to the `FrameController` to load its contents. However, once visible, subsequent navigations of that frame will continue to be deferred, since its `[loading]` attribute is still deferred, in spite of the fact that the element is visible on that page. Proposed change --- This commit proposes to immediately navigate a `<turbo-frame>` element with `[loading="eager"]` _or_ a `<turbo-frame>` element that has been loaded previously. Possible alternatives --- As an alternative to adding another conditional to the guard clause, could it be worthwhile to treat navigational changes driven by `<a>` clicks or `<form>` submissions different from programatically modifying the element's `[src]` attribute? Do Custom Elements support changing an attribute's value without also kicking off change callbacks?
- Loading branch information
1 parent
8bce5f1
commit 90a806d
Showing
3 changed files
with
21 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters