Error is logged in console when response has no matching <turbo-frame>

[alexandreruban]

When loading a frame and the response does not have a matching <turbo-frame> with the same id, an error is logged in the console in FrameController#extractForeignFrameElement. It was discussed in this issue #31.

However, I think this causes an issue in most Rails apps.

Steps to reproduce

Let's imagine a simple CRUD controller on a quote resource. The destroy action in the controller would look like this:

# app/controllers/quotes_controller.rb

def destroy
  @quote.destroy # Destroy the quote
  redirect_to quotes_path # Redirect to index page
end

In the QuotesController#index page, I render the collection of quotes:

<%# app/views/quotes/index.html.erb %>

<%= render @quotes %>

The markup for a quote is in the app/views/quotes/_quote.html.erb partial:

<%# app/views/quotes/_quote.html.erb %>

<%= turbo_frame_tag quote do %>
  <div class="quote">
    <span>Irrelevant markup</span>
    <%= button_to "Destroy", quote, method: :delete %> 
  </div>
<% end %>

Actual behavior

When clicking on the "Destroy" button for a quote, the quote is removed, but I get an error in console: Response has no matching <turbo-frame id="quote_1"> element. The empty frame remains in the DOM.

Expected behavior

The <turbo-frame id="quote_1"> is removed from the DOM completely. No error is logged in the console.

What do you think?

If you agree with the expected behavior, I would love to make a PR.

If what is expected when destroying a resource is to always distinguish the html and turbo_stream formats, then I would love to document it somewhere:

# app/controllers/quotes_controller.rb

def destroy
  @quote.destroy
  respond_to do |format|
    format.html { redirect_to quotes_path }
    format.turbo_stream
  end
end

[kylekeesling]

It looks like you may be missing one piece.

In order to remove the quote from the page you need a corresponding destroy.turbo_stream.erb view or you’d need to explicitly write the code to remove the quote from the page in your controller response. Would look something like:

in a view - destroy.turbo_stream.erb

turbo_stream.remove @quote

Or in your controller:

respond_to do |format|
  format.html { redirect_to quotes_path } 
  format.turbo_stream { turbo_stream.remove @quote } 
end

[tleish]

@alexandreruban - You might be interested in these discussions:

see:

• Ability to override frame-target from server response #257
• Render 4xx responses within frame #210 (comment)

I'm curious if any of these solutions might solve what you are trying to accomplish (e.g. replace the entire page with the response if the response from the server does not include a matching turbo-frame#id), or are you trying to accomplish something different?