Breaking change in 7.2, when frame response is 4xx, 5xx OR if frame is missing

[cabgfx]

On updating from Turbo 7.1.x to to 7.2.x, via turbo-rails, we were quite surprised to see frames suddenly doing full-page redirects on failures, ie. for a 4xx or 5xx response.

I'm aware of #445, and the reasoning behind the turbo:frame-missing event, quite useful!

However, the changes introduced in #693, where Turbo now transforms 4xx and 5xx responses to full-page Visits, feel like a breaking change. The minor version bump from 7.1 to 7.2 certainly broke our app 😅

I've read up on the discussion in #670, and noticed this sentiment by @seanpdoyle :

Scenarios like this make me nervous about breaking the #94 (comment) that a navigation within a frame will stay within a frame.

I believe the changes introduced in 7.2 specifically break that “promise”: a navigation within a frame will stay within a frame

Are apps now required to add additional/custom JS by default, to handle this scenario?

Or am I simply misunderstanding something? (quite possible!)

---

Related:

• Original issue raised on Breaking change in 7.2, when frame response is 4xx, 5xx OR if frame is missing turbo-rails#407, was told to post here instead
• Issue Mark forms created for links with data-turbo-method as hidden #404
• A minimal test app that reproduces my issue: https://github.com/cabgfx/turbo72-repro

[dhh]

@kevinmcconnell is working on a new feature for 7.3 where we refine this such that only paths from an allowlist, like redirects to /sign_in, will break out of the frame, and other 4xx and 5xx responses will instead stay in the frame, but fill it with an error message. That'll address the original concern where session timeouts would just fail, and the problem with 500s just causing a white screen and no user feedback.

[kevinmcconnell]

I should have a PR ready for that in the next couple of days.

[cabgfx]

Awesome! Appreciate your work on this! If I can assist with testing it out or anything, please let me know

[duffyjp]

... only paths from an allowlist, like redirects to /sign_in, will break out of the frame, and other 4xx and 5xx responses will instead stay in the frame, but fill it with an error message.

This is a great plan! 🎉

Will it be possible to get the details of what went wrong in the console?

[jon-sully]

Just for breadcrumbs' sake, the allow-list concept ended up getting scrapped in #864 to instead create a flag (of sorts) to put on the incoming page which forces Turbo to full-visit the page, even if the request originated from within a frame

[jon-sully]

And with 7.3 I think this issue is closable 😁

[cabgfx]

Thanks for the heads-up, @jon-sully!