Move Cache instantiation to Session
#1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `Cache` class was [introduced in a54ac17][], it depended on a `Session` instance. When it was [modified in f86a376][], that dependency was no longer necessary. This commit preserves the export of the `Turbo.cache` property while re-arranging the location it's declared. Instead of instantiating the `Cache` instance in `@hotwired/turbo/core/`, this commit defines it as a property on the `Session` instance. [introduced in a54ac17]: hotwired@a54ac17 [modified in f86a376]: hotwired@f86a376
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Oct 8, 2023
|
Good catch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Cacheclass was introduced in a54ac17, it depended on aSessioninstance. When it was modified in f86a376, that dependency was no longer necessary.This commit preserves the export of the
Turbo.cacheproperty while re-arranging the location it's declared. Instead of instantiating theCacheinstance in@hotwired/turbo/core/, this commit defines it as a property on theSessioninstance.