Revert disk cache store #1062
Merged
Revert disk cache store #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
approved these changes
Nov 13, 2023
kevinmcconnell
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Looks good @afcapel.
It's a shame if the disk cache doesn't end up making it into v8, but I agree with you about the priorities so it's a good call to take it back out for now.
| @@ -62,11 +62,11 @@ setup(() => { | |||
| Turbo.registerAdapter(adapter) | |||
| }) | |||
|
|
|||
| test("navigator adapter is native adapter", async () => { | |||
| test("test navigator adapter is native adapter", async () => { | |||
There was a problem hiding this comment.
I think the extraneous test in the descriptions were removed after the original changes were added, and so reverting is bringing some of them back. Might we worth removing them again as an additional commit in this PR, for consistency?
There was a problem hiding this comment.
Good point, I've added the commits to the branch.
The branch was gone, so I had to recreate the commits. Definitely one case in which squashing the branch was not very helpful.
afcapel
pushed a commit
that referenced
this pull request
Nov 14, 2023
afcapel
added a commit
that referenced
this pull request
Nov 14, 2023
* origin/main: Revert disk cache store (#1062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #949 and the follow up PRs #1014 and #1056.
The idea is still appealing but we've found several hard-to-debug issues while testing this in our applications. Most notably we found some meta tags propagating outside the original page on navigation, and issues with the timing of
turbo:loadevents.These issues are solvable, but our priority right now is shipping Page Refreshes ahead of Turbo v8.