Restructure to avoid internal window.Turbo access
#1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah @seanpdoyle could you please rebase to solve conflicts? |
seanpdoyle
force-pushed
the
replace-window-turbo-access-from-fetch
branch
from
db84bb5
to
586f811
Compare
Replace accessing the `recentRequests` property through the `window.Turbo.session` object. In its place, restructure the object's dependency graph so that the `http/fetch` module constructs the `LimitedSet` instance, and the `Session` accepts that instance as a property.
seanpdoyle
force-pushed
the
replace-window-turbo-access-from-fetch
branch
from
586f811
to
23d0cb4
Compare
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Dec 1, 2023
Follow-up to [hotwired#1049][] Follow-up to [hotwired#1073][] Related to [hotwired#1078][] Replace an internal `window.Turbo.session` access with an `import { session }` statement. Prior attempts at this change introduced circular dependencies. This attempt does not. Additionally, this change maintains the ability for consumers to access StreamActions through `window.Turbo.StreamActions`, while also enabling `import { StreamActions } from "@hotwired/turbo"` (or `from "@hotwired/turbo-rails"`). [hotwired#1049]: hotwired#1049 [hotwired#1073]: hotwired#1073 [hotwired#1078]: hotwired#1078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace accessing the
recentRequestsproperty through thewindow.Turbo.sessionobject.In its place, restructure the object's dependency graph so that the
http/fetchmodule constructs theLimitedSetinstance, and theSessionaccepts that instance as a property.