Fix attribute name #1134
Merged
Fix attribute name #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attribute name is `data-tag-name` not `data-page-name`. Ref. https://github.com/basecamp/trix/blob/06d8b1db5fb682d007c5ca041884f6297674c8b7/src/trix/core/helpers/custom_elements.js#L10-L11
afcapel
added a commit
to pfeiffer/turbo
that referenced
this pull request
Jan 29, 2024
* origin/main:
Introduce `turbo:{before-,}morph-{element,attribute}` events
Turbo 8.0.0-beta.4
Introduce data-turbo-track="dynamic" (hotwired#1140)
Ensure that the turbo-frame header is not sent when the turbo-frame has a target of _top (hotwired#1138)
Turbo 8.0.0-beta.3
Fix attribute name (hotwired#1134)
Add InstantClick behavior (hotwired#1101)
Revert hotwired#926. (hotwired#1126)
Keep Trix dynamic styles in the head (hotwired#1133)
Remove unused stylesheets when navigating (hotwired#1128)
Upgrade idiomorph to 0.3.0 (hotwired#1122)
Debounce page refreshes triggered via Turbo streams
Update copyright year to 2024 (hotwired#1118)
Turbo 8.0.0-beta.2
Set aria-busy on the form element during a form submission (hotwired#1110)
Dispatch `turbo:before-fetch-{request,response}` during preloading (hotwired#1034)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute name is
data-tag-namenotdata-page-name.Ref. https://github.com/basecamp/trix/blob/06d8b1db5fb682d007c5ca041884f6297674c8b7/src/trix/core/helpers/custom_elements.js#L10-L11