turbo-frame[busy] attribute #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regardless of how we feel about aria-busy, I think the first commit to add test coverage for the attribute is worthwhile. |
seanpdoyle
commented
Feb 4, 2021
seanpdoyle
force-pushed
the
frame-busy
branch
from
31b17b0
to
6c9151a
Compare
|
Since the original work uncovered some bugs we'd like to ship more immediately, I've split out #157 to serve as the conversation venue for |
seanpdoyle
force-pushed
the
frame-busy
branch
2 times, most recently
from
ac43dc1
to
79950a7
Compare
seanpdoyle
commented
Feb 4, 2021
seanpdoyle
force-pushed
the
frame-busy
branch
3 times, most recently
from
639ecf6
to
c0970f5
Compare
seanpdoyle
force-pushed
the
frame-busy
branch
2 times, most recently
from
88d4792
to
0737fb3
Compare
During the request lifecycle, `<turbo-frame>` elements will toggle the `[busy]` boolean attribute to true when the request starts, and then remove it when the request ends. This commit adds functional test coverage for that behavior, along with a `RemoteChannel` to transmit `MutationObserver` records from the browser to the test harness.
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the request lifecycle,
<turbo-frame>elements will toggle the[busy]boolean attribute to true when the request starts, and thenremove it when the request ends.
Additionally, form submissions were not triggering the same
[busy]toggling behavior, so this commit adds coverage for that behavior as well.This commit adds functional test coverage for that behavior.