Focus [autofocus] on navigation and frame load #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the `<input>` element's documentation for the `[autofocus]` attribute: > A Boolean attribute which, if present, indicates that the input should > automatically have focus when the page has finished loading > > > Note: An element with the `[autofocus]` attribute may gain focus > before the `DOMContentLoaded` event is fired. No more than one element > in the document may have the `[autofocus]` attribute. If put on more > than one element, the **first one with the attribute receives focus**. [autofocus]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input#htmlattrdefautofocus
seanpdoyle
force-pushed
the
frame-autofocus
branch
from
f0c43a0
to
f2e2f32
Compare
During the rendering process, the `PageRenderer` replaces the current `Snapshot` with the contents of the new `Snapshot`, while the `FrameRenderer` extracts the contents of the new Snapshot and uses it to replace the contents of the current `Snapshot`. Instead of accepting a `Snapshot` as an argument, `Renderer.focusFirstAutofocusableElement()` uses whichever `Snapshot` is connected to the current document. Co-authored-by: Javan Makhmali <javan@basecamp.com>
Add test coverage for preserving turbo-frame attributes during render, making sure that any element state is preserved while the contents are modified.
seanpdoyle
force-pushed
the
frame-autofocus
branch
from
2b54b0a
to
b643f1d
Compare
seanpdoyle
commented
Feb 8, 2021
javan
approved these changes
Feb 8, 2021
This was referenced Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus autofocus on navigation and frame load
According to the
<input>element's documentation for the[autofocus]attribute:Focus the Snapshot that is connected to the DOM
During the rendering process, the
PageRendererreplaces the currentSnapshotwith the contents of the newSnapshot, while theFrameRendererextracts the contents of the new Snapshot and uses it toreplace the contents of the current
Snapshot.Instead of accepting a
Snapshotas an argument,Renderer.focusFirstAutofocusableElement()uses whicheverSnapshotisconnected to the current document.
Co-authored-by: Javan Makhmali javan@basecamp.com
Test coverage to preserve turbo-frame attributes
Add test coverage for preserving turbo-frame attributes during render,
making sure that any element state is preserved while the contents are
modified.
Skip autofocus during previews
Pass the
isPreviewvalue to theView.renderPage()call, and thenrestore the guard clause removed by a7d02f0.