Don't duplicate Form Submitter [name] param #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `<form>` element's submitter declares a `[name]` attribute without a `[value]` attribute, it is appended to the submission's `FormData` instance twice. Due to a quirky difference between Safari and Firefox + Chrome, the duplication _only_ occurs in Safari, which is a browser that we are not running our functional test suite against. In spite of that, this commit adds test coverage to ensure we don't introduce a similar regression into those browsers. Testing --- Oddly enough, there are several occurrences of doubled-up `await await` keywords, which this commit removes.
|
What would it take to run intern against Safari in CI? Browserstack? GitHub Actions running on macOS? |
I don't recall the specifics, but there's problems with running the test suite under Safari that are not CI- or Intern-related. |
|
Thank you! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
<form>element's submitter declares a[name]attributewithout a
[value]attribute, it is appended to the submission'sFormDatainstance twice. Due to a quirky difference between Safari andFirefox + Chrome, the duplication only occurs in Safari, which is a
browser that we are not running our functional test suite against.
In spite of that, this commit adds test coverage to ensure we don't
introduce a similar regression into those browsers.
Testing
Oddly enough, there are several occurrences of doubled-up
await awaitkeywords, which this commit removes.