Add a "reload" method to the frame element #206
Conversation
src/elements/frame_element.ts
Outdated
| const srcAttribute = this.src; | ||
| this.src = null; | ||
| this.src = srcAttribute; |
There was a problem hiding this comment.
We've using ES6 here, so let's do:
| const srcAttribute = this.src; | |
| this.src = null; | |
| this.src = srcAttribute; | |
| const { src } = this | |
| this.src = null | |
| this.src = src |
|
|
||
| const frameContent = "#loading-eager turbo-frame#frame h2" | ||
| this.assert.ok(await this.hasSelector(frameContent)) | ||
| // @ts-ignore |
There was a problem hiding this comment.
because otherwise typescript complains that reload is not an Element method.
shall I cast it instead?
| this.assert.ok(await this.hasSelector(frameContent)) | ||
| // @ts-ignore | ||
| await this.remote.execute(() => document.querySelector("#loading-eager turbo-frame")?.reload()) | ||
| this.assert.ok(await this.hasSelector(frameContent)) |
There was a problem hiding this comment.
Looks like we're using tabs for some of these lines, can you switch to just spaces?
| await this.remote.execute(() => document.querySelector("#loading-eager turbo-frame")?.reload()) | ||
| this.assert.ok(await this.hasSelector(frameContent)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Our style before didn't add an extra line, so we should cut this one too.
Can the |
|
I am not sure how to achieve that. The target of |
|
@coorasse may i suggest an additional improvement to this PR would for the reload() function to accept an optional parameter to specify the URL to set src as. This would be useful if you don't already have one, and want to set it as a the same URL, or if for some reason the URL changes and you want it pointing somewhere else. |
As proposed in #202, this PR adds a
.reload()method on the frame that allows to refresh its content.Open points:
reload()will simply have no effect. To me this is simple and stupid, so it should be fine.